Promote v12 beta into master #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove build assets, bower.json and exclude
* install react, react-dom 18 * use createRoot instead of render * use @cfaester/enzyme-adapter-react-18 and update snapshots * fix up async issues in E2E tests * run yarn upgrade * fix up another failing async test with helpers * use lts browsers in Circle build * remove dependency on 'node-fetch' * use UNSAFE_ for componentWilReceiveProps
* use @cfaester/enzyme-adapter-react-18 and update snapshots * fix up async issues in E2E tests * run yarn upgrade * upgrade to webpack 3 * upgrade webpack to 4.x * wip - upgrade to babel 7 * upgrade UnminifiedWebpackPlugin * update jest to latest and update tests & snapshots * update karma dependencies * upgrade to webpack 5 * adding polyfills * tweaks to fix e2e tests * enable browserstack tests on IE11 * attempting to fix concurrency issues in browserstack runs * add new line for browserslistrc * Update src/__tests__/core/index.test.js Co-authored-by: Rita Zerrizuela <zeta@widcket.com> Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Update readme for the beta
* chore: update docs for GA release * chore: build lockfile using yarn@2
* Bump auth0-js from 9.19.2 to 9.20.0 (#2221) Bumps [auth0-js](https://github.com/auth0/auth0.js) from 9.19.2 to 9.20.0. - [Release notes](https://github.com/auth0/auth0.js/releases) - [Changelog](https://github.com/auth0/auth0.js/blob/master/CHANGELOG.md) - [Commits](auth0/auth0.js@v9.19.2...v9.20.0) --- updated-dependencies: - dependency-name: auth0-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * IAMRISK-1790 Support captcha for Passwordless (#2222) * initial changes for email passwordless login screen * updated tests * Fix test for passwordless/social_or_email_login_screen Fixes for a couple of issues: **Circular dependency error** Thanks to the email field, it was trying to use a function `isHRDEmailValid` from 'connection/enterprise', which isn't necessary for this test (I don't *think* you can have enterprise passwordless connections, you would just use the non-passwordless version of Lock). Mocking out this module and just returning `false` for `isHRDEmailValid` makes things simpler. **m.getIn is not a function** This is down to `social_or_email_login_screen` calling `hasSomeConnections` from 'core/index', this can simply be mocked to return `true` for this test. This function just verifies that there is a passwordless or email connection available. I also had to mock out i18n.html, as this function is called when the component renders. * add capthca pane to social or email login screen (failing tests) * Remove unneeded lines * add captcha to passwordless login screens, with unit tests passing * got rid of sso * got rid of enterprise check * deleted unncessary imports * Captcha support for Passwordless * Update passwordless snapshots * Error translations * Swap captcha if restarting passwordless * Add missing fun argument docs * Use invalid_recaptcha error key for recaptcha_enterprise * Resolve deps publicly * Fix bug to correctly reset captcha field * Remove conditional for non objects * Add missing translations Co-authored-by: kaki1104 <kaki.so2011@gmail.com> Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com> * Release v11.35.0 (#2223) release v11.35.0 * Bump eslint-config-prettier from 8.5.0 to 8.6.0 Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.5.0 to 8.6.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.5.0...v8.6.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump dompurify from 2.4.1 to 2.4.3 (#2232) Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.4.1 to 2.4.3. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.4.1...2.4.3) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 2.8.1 to 2.8.2 (#2231) Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.1...2.8.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eslint-plugin-react from 7.31.11 to 7.32.0 (#2233) Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.31.11 to 7.32.0. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.31.11...v7.32.0) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 2.8.2 to 2.8.3 (#2237) * Bump auth0-js from 9.20.0 to 9.20.1 (#2235) * Bump eslint-plugin-react from 7.32.0 to 7.32.1 (#2238) Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.32.0 to 7.32.1. - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.32.0...v7.32.1) --- updated-dependencies: - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.7 to 2.6.8 (#2236) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.7 to 2.6.8. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.7...v2.6.8) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rita Zerrizuela <zeta@widcket.com> Co-authored-by: Steve Hobbs <steve.hobbs@hey.com> * Use latest ship-orb in CI (#2234) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Robin Bijlani <robinbijlani@gmail.com> Co-authored-by: kaki1104 <kaki.so2011@gmail.com> Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com> Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,6 +1,7 @@ | |||
| import React from 'react'; // eslint-disable-line | |||
| import renderer from 'react-test-renderer'; | |||
| import ShallowRenderer from 'react-test-renderer/shallow'; | |||
| import { JavascriptModulesPlugin } from 'webpack'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
Widcket
approved these changes
Jan 20, 2023
matan04
reviewed
Jan 26, 2023
| } | ||
|
|
||
| remove(containerId) { | ||
| if (this.modals[containerId]) { | ||
| this.modals[containerId].hide(); | ||
| this.modals[containerId].component.hide(); |
There was a problem hiding this comment.
My app is crashing on this line.
On IOS (Mobile Safari UI/WKWebVie) / MAC (chrome 109) sometimes when unmount auth0-lock, i'm not sure how to reproduce it always so not sure I can open an issue about it.
I suggest maybe to optional call hide() ?
This: this.modals?.[containerId]?.component?.hide?.();
or this: this.modals[containerId].component &&this.modals[containerId].component.hide();
Hope this helps,
Thanks 🙏🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.